Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
davesnx
force-pushed
the
grammar-clamp-env
branch
from
September 22, 2026 12:46
9b0ce60 to
ffd67f7
Compare
davesnx
force-pushed
the
parser-dead-tokens-roundtrip
branch
2 times, most recently
from
September 22, 2026 13:32
df0f4b6 to
f91c225
Compare
davesnx
force-pushed
the
grammar-clamp-env
branch
from
September 23, 2026 06:11
514f771 to
54f5961
Compare
davesnx
force-pushed
the
parser-dead-tokens-roundtrip
branch
from
September 23, 2026 06:11
f91c225 to
09a631a
Compare
davesnx
force-pushed
the
parser-dead-tokens-roundtrip
branch
from
September 23, 2026 06:39
09a631a to
f75110b
Compare
davesnx
force-pushed
the
grammar-clamp-env
branch
from
September 23, 2026 06:39
54f5961 to
9be6963
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two parser housekeeping items from the quality audit.
Tokens.reloses three constructors nothing ever built (TYPE_SELECTOR,AT_KEYWORD,DESCENDANT_COMBINATOR), leftovers from before the lexer unification. Andpackages/parser/testgains the round-trip regression check it never had: for each CSS body,render(parse(css))must equalrender(parse(render(parse(css)))), and the re-parsed AST must equal the first parse modulo locations and the incidental whitespace tokens the renderer strips.The corpus is 48 bodies: 30 copied from the css-support cram fixtures plus 18 edge cases (
@supports,@container,calc(),var(),url(),:is()/:where()/:not()/:has(), attribute selectors,::before,.5/-.5/1e3, escaped strings, comments). All 48 pass both checks. One real divergence is pinned as an explicit known-divergence test rather than hidden: an unquotedurl(foo.png)parses to the dedicatedAst.Urinode, but the renderer always emits a quoted argument and the quoted form re-parses as a genericFunction("url", …), soAst.Urinever survives a render pass. Text output is unaffected; the AST shape is. Candidate defect for a follow-up.Evidence at 8500fab:
opam exec -- dune build --root . @test-parser: 334 tests, 99 of them the newRoundtrip_testmodule (48 render-stability, 48 AST-stability, 1 pinned divergence, 2 render-only).make format-check,make build,make test: all exit 0.Risk: two-way door. Deletion of unused constructors and test-only code; no output changes.