Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
davesnx
force-pushed
the
lexer-signed-fraction
branch
from
September 22, 2026 12:46
9fe43f3 to
f436aed
Compare
davesnx
force-pushed
the
grammar-clamp-env
branch
2 times, most recently
from
September 22, 2026 13:32
ffd67f7 to
514f771
Compare
davesnx
force-pushed
the
lexer-signed-fraction
branch
2 times, most recently
from
September 23, 2026 06:11
07d18ea to
76558b4
Compare
davesnx
force-pushed
the
grammar-clamp-env
branch
from
September 23, 2026 06:11
514f771 to
54f5961
Compare
davesnx
force-pushed
the
lexer-signed-fraction
branch
from
September 23, 2026 06:39
76558b4 to
fe08a21
Compare
davesnx
force-pushed
the
grammar-clamp-env
branch
from
September 23, 2026 06:39
54f5961 to
9be6963
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clamp()andenv()were fully implemented as grammar functions but no property could reach them: the sharedExtended_lengthandExtended_percentagevalue types listedcalc(),min()andmax()as their math alternatives and nothing else, sowidth: clamp(10px, 5vw, 100px)andpadding-top: env(safe-area-inset-top)were rejected with "invalid value". The Ahrefs monorepo works around it with an inline style. Both functions are now alternatives wherevercalc()already is:clamp()on length, percentage, angle, time and frequency;env()on length and percentage, the only types it produces. Fixing this exposed a second defect:env()'s own grammar demanded a comma even without a fallback, so the commonenv(safe-area-inset-top)form failed; the grammar now readsenv( <custom-ident> [ ',' <declaration-value> ]? ).Evidence at e1c6df5:
packages/ppx/test/css-support/clamp-env-functions.t: six declarations, all rejected before with the "Expected 'length', 'percentage', 'calc()', … 'min()'" message, all rendered after as passthrough text likecalc().Types.mlgains the matching variant arms; the runtime witnesses are unchanged because these values render as text.make format-check,make build,make test: all exit 0.Risk: two-way door. Only previously rejected values change behaviour; no existing output or hash changes.