chore: Remove unused keyring dependency#1588
Open
sd-db wants to merge 3 commits into
Open
Conversation
Remove obsolete lockfile entries and skipped legacy keyring tests.
sd-db
changed the title
Coverage report
This PR does not seem to contain any modification to coverable code. |
sd-db
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #
Description
dbt-databricksno longer useskeyring; token caching moved to the Databricks SDK, but the direct dependency and its old lock entries remained. This removes the unused direct dependency, stale transitive packages from both lockfiles, and skipped tests that only exercised the retired keyring-backed implementation. There is no runtime authentication behavior change.Checklist
hatch run pytest tests/unit/test_auth.py -q -n 0 --profile databricks_cluster— 19 passed, 2 skippedhatch run code-quality— passed, includinguv-lockand the public-PyPI URL checkuv.lockgraph — 103 packages with no missing dependency referencesCHANGELOG.mdand added information about my change to the "dbt-databricks next" section.