Skip to content

Improve ASP.NET Core docs and reference NuGet library#5164

Merged
msfussell merged 2 commits into
dapr:v1.17from
erwinkramer:v1.17
May 23, 2026
Merged

Improve ASP.NET Core docs and reference NuGet library#5164
msfussell merged 2 commits into
dapr:v1.17from
erwinkramer:v1.17

Conversation

@erwinkramer
Copy link
Copy Markdown
Contributor

@erwinkramer erwinkramer commented May 16, 2026

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within tabpane
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have tabpane

In addition, please fill out the following to help reviewers understand this pull request:

Description

This PR:

  • Fixes the UseJsonSerializationOptions reference to use the right value. UseJsonSerializerOptions doesn't exist (anymore).
  • Makes it clear what is library is required for dependency injection on ASP.NET Core.
  • Small doc formatting

Signed-off-by: Erwin <erwinkramer@hotmail.com>
@erwinkramer erwinkramer requested review from a team as code owners May 16, 2026 08:23
Copy link
Copy Markdown
Contributor

@nelson-parente nelson-parente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-review for @marcduiker handoff: LGTM with nits.

  • Fixes UseJsonSerializerOptionsUseJsonSerializationOptions (correct method name) — this is an actual bug fix, good catch.
  • Adds NuGet install step for Dapr.AspNetCore before the DI usage examples — helpful for newcomers.
  • Trailing whitespace removals are cosmetic, no concern.
  • Nit: the PR branch is named v1.17 but targets main — double-check if this is a backport or a main-branch update; if it's main-only the branch name is misleading but harmless.
    Nothing blocking — Marc, your call.

Copy link
Copy Markdown
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit 9084c13 into dapr:v1.17 May 23, 2026
7 checks passed
marcduiker pushed a commit to marcduiker/dapr-docs that referenced this pull request May 25, 2026
Signed-off-by: Erwin <erwinkramer@hotmail.com>
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants