Skip to content

DAOS-18694 tests: test for container recovery when inc-reint#17938

Open
Nasf-Fan wants to merge 1 commit intomasterfrom
Nasf-Fan/DAOS-18694_1
Open

DAOS-18694 tests: test for container recovery when inc-reint#17938
Nasf-Fan wants to merge 1 commit intomasterfrom
Nasf-Fan/DAOS-18694_1

Conversation

@Nasf-Fan
Copy link
Copy Markdown
Contributor

@Nasf-Fan Nasf-Fan commented Apr 8, 2026

Related C test logic has already been there, only add related python interface to enable CI test.

Skip-nlt: true
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: cont_recov

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Ticket title is 'Enable test for container recovery when incremental reintegration'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-18694

@daosbuild3
Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17938/1/execution/node/736/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-18694_1 branch 3 times, most recently from 36ea790 to 7458548 Compare April 11, 2026 09:13
Related C test logic has already been there, only add related python
interface to enable CI test.

Skip-nlt: true
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: cont_recov

Signed-off-by: Fan Yong <[email protected]>
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-18694_1 branch from 7458548 to 8a8832f Compare April 14, 2026 04:53
@Nasf-Fan Nasf-Fan marked this pull request as ready for review April 16, 2026 04:15
@Nasf-Fan Nasf-Fan requested review from a team as code owners April 16, 2026 04:15
@Nasf-Fan
Copy link
Copy Markdown
Contributor Author

Pass all specified CI tests

Copy link
Copy Markdown
Contributor

@phender phender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically we've placed tests running daos_test in the ftest/daos_test directory - like ftest/daos_test/rebuild.py. If we plan to have multiple reintegration tests does it make sense to have a ftest/daos_test/reintegration.py test file/yaml?

@phender
Copy link
Copy Markdown
Contributor

phender commented Apr 16, 2026

Historically we've placed tests running daos_test in the ftest/daos_test directory - like ftest/daos_test/rebuild.py. If we plan to have multiple reintegration tests does it make sense to have a ftest/daos_test/reintegration.py test file/yaml?

I also do like having a rebuild related test in the ftest/rebuild directory. It would just be good to have consistency - something outside the scope of this PR.


:avocado: tags=all,daily_regression
:avocado: tags=hw,medium,provider
:avocado: tags=inc_reint,cont_recov
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI we should add the daos_test and probably rebuild tags as well
But I have another PR #17975 where I will handle this so you don't need to repush for just this

Suggested change
:avocado: tags=inc_reint,cont_recov
:avocado: tags=daos_test,rebuild,inc_reint,cont_recov

@daltonbohning daltonbohning changed the title DAOS-18694 tests: test for contaner recovery when inc-reint DAOS-18694 tests: test for container recovery when inc-reint Apr 16, 2026
@Nasf-Fan
Copy link
Copy Markdown
Contributor Author

Historically we've placed tests running daos_test in the ftest/daos_test directory - like ftest/daos_test/rebuild.py. If we plan to have multiple reintegration tests does it make sense to have a ftest/daos_test/reintegration.py test file/yaml?

Currently, we support full reintegration, means reintegrate rank/target from scratch. We have related tests cases, but I do not know why they are not under reintegration.py. I am not the maintainer for rebuild/reintegration, but I guess that it may because the logic for reintegration and rebuild are quite similar, then they were misc together at the beginning.

On the other hand, full reintegration may cause too much overhead for a large system, then we plan to support incremental reintegration in 3.0 release. So I made patch to handle container recovery for the coming incremental reintegration that will be done by @liuxuezhao in future. These test cases in inc_reint.xxx are just for such purpose. I am not sure @liuxuezhao 's plan about how to organize related test cases for incremental reintegration since the main part is not completed yet. But the logic for handling container recovery has already been landed to master. So I prefer to enable these test cases in inc_reint.xxx relative independently, and waiting for @liuxuezhao 's main part to be completed, and at that time, @liuxuezhao may re-organize related test cases together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants