fix(control): preserve DNS state for group override options#997
Open
ayanamists wants to merge 1 commit into
Open
fix(control): preserve DNS state for group override options#997ayanamists wants to merge 1 commit into
ayanamists wants to merge 1 commit into
Conversation
2c5e65c to
a048e24
Compare
jschwinger233
approved these changes
May 11, 2026
Member
|
貌似没有大问题,不过我不是特别熟悉 dns 这一部分,其他人有空的话也可以帮忙看一眼。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
When a group overrides health-check options, dae rebuilds a
GlobalOptionfor cloned dialers. That rebuilt option preserved the transport cache namespace at the call site, but it did not preserve runtime state injected into the base option, especiallyDaeDNS.As a result, cloned dialers in groups with
tcp_check_url,udp_check_dns,check_interval, orcheck_toleranceoverrides could skipDaeDNS.WrapNodeDialer(...)and fall back to the default resolver for node hostnames.This patch passes the base option into
ParseGroupOverrideOptionand preserves the runtime fields needed by cloned dialers.Tests
go test -tags dae_stub_ebpf ./control -run TestParseGroupOverrideOptionPreservesRuntimeDialerState -count=1go test -tags dae_stub_ebpf ./control -count=1