Skip to content

Fix #58: highlight script attributes appearing before type#115

Merged
daaain merged 1 commit into
masterfrom
fix/script-tag-attribute-order
Jun 29, 2026
Merged

Fix #58: highlight script attributes appearing before type#115
daaain merged 1 commit into
masterfrom
fix/script-tag-attribute-order

Conversation

@daaain

@daaain daaain commented Jun 29, 2026

Copy link
Copy Markdown
Owner

The inline_script rule matched the opening <script> tag with a greedy .*type= that consumed every character up to the type attribute. Any attribute placed before type (e.g. <script id="foo" type="...">) was swallowed into a single unscoped token and lost its highlighting.

Replace the consuming .*type=... with a non-consuming lookahead that only asserts a handlebars type exists somewhere in the tag, so the begin match ends right after <script and the existing #tag-stuff rules highlight every attribute regardless of order. The now-unused type/value beginCaptures are removed.

Applied to all three grammar files. Adds regression tests covering both attribute orders plus a guard that a plain text/javascript script is not treated as a handlebars embedding.

The inline_script rule matched the opening <script> tag with a greedy
`.*type=` that consumed every character up to the type attribute. Any
attribute placed before type (e.g. <script id="foo" type="...">) was
swallowed into a single unscoped token and lost its highlighting.

Replace the consuming `.*type=...` with a non-consuming lookahead that
only asserts a handlebars type exists somewhere in the tag, so the begin
match ends right after <script and the existing #tag-stuff rules
highlight every attribute regardless of order. The now-unused type/value
beginCaptures are removed.

Applied to all three grammar files. Adds regression tests covering both
attribute orders plus a guard that a plain text/javascript script is not
treated as a handlebars embedding.
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@daaain, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 3 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e1b8418f-7ca7-4cf5-b522-abac6ad1b9e3

📥 Commits

Reviewing files that changed from the base of the PR and between adc200e and 99c1a11.

📒 Files selected for processing (4)
  • grammars/Handlebars.json
  • grammars/Handlebars.sublime-syntax
  • grammars/Handlebars.tmLanguage
  • test/embedding.test.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/script-tag-attribute-order

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@daaain daaain merged commit 39e21b2 into master Jun 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant