fix: pin uv installation to 0.12.0 across scripts - #46
Open
ai-anant wants to merge 1 commit into
Open
Conversation
Centralize the uv version in scripts/install.sh via a single UV_VERSION variable (matching requirements-uv.txt and pyproject.toml's required-version), use the versioned astral installer URL on macOS/Linux instead of the unpinned latest installer, and fix the stale uv==0.11.32 fallback on Windows (which violated the project's required-version constraint). Update setup-dev.sh hint and scripts/README.md to match. Fixes cyfinoid#3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #3 (uv installation shenanigans). The CI workflows were already migrated to the pinned
astral-sh/setup-uvaction (version 0.12.0), but the local install scripts still had inconsistent/unpinned uv installs:Changes
UV_VERSION="0.12.0"variable as the source of truth, matchingrequirements-uv.txt(hashed pin) andpyproject.toml[tool.uv] required-version = ">=0.12.0,<0.13.0".https://astral.sh/uv/${UV_VERSION}/install.shinstead of the unpinned latestinstall.sh.uv==0.11.32(which violated the project's required-version constraint and would breakuv sync) touv==${UV_VERSION}.Verification
bash -n scripts/install.sh scripts/setup-dev.sh→ syntax OKpytest tests/→ 6 passedhttps://astral.sh/uv/0.12.0/install.sh(HTTP 200)0.11.32/ unpinnedastral.sh/uv/install.shreferences inscripts/or.github/Fixes #3