Fix midiplayer slider / note off (0.23.1)#311
Merged
Conversation
The capsule's `dragstart` handler had been dead since the jQuery removal in 98529ff: HTML5 `dragstart` only fires on draggable="true" elements, so clicking the timeline did nothing and `this.state` was never set. Overlay an invisible `<input type="range">` over the existing capsule/cursor visuals and scrub via `input` events, pausing on `pointerdown` and resuming on `pointerup` if playback was active. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Switch .timeControls to flex with align-items: center so the time labels and capsule line up on the player's vertical midline instead of relying on per-element `top` nudges (`top: 5px` on the row, `top: -9px` on the labels). AI-Assisted (Claude)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the slider and time display on MIDIPlayer. Attempt to get better NoteOff via upgrade to MIDICube 0.10.1.
MIDICube 0.10.0 also allows for playing notes below A0 and above C8 if samples are given there.
AI-Assisted, Claude