Repository navigation
wcurl: document how --curl-options splits its value - #103
Merged
Merged
Conversation
The value of --curl-options is split on whitespace into separate curl arguments, and quotes and backslashes are not interpreted, but the documentation never said so. Someone passing a header whose value contains spaces, e.g.: wcurl --curl-options='-H "Cookie: a=1; b=2"' example.com ends up with curl receiving '-H', '"Cookie:', 'a=1;' and 'b=2"', and treating the extra words as URLs to download. Spell out the splitting rule, point to curl's '--config' or to using curl directly for arguments containing whitespace, and warn against building the value from untrusted input. Thanks to Harry Sintonen for reporting the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value of --curl-options is split on whitespace into separate curl arguments, and quotes and backslashes are not interpreted, but the documentation never said so. Someone passing a header whose value contains spaces, e.g.:
wcurl --curl-options='-H "Cookie: a=1; b=2"' example.com
ends up with curl receiving '-H', '"Cookie:', 'a=1;' and 'b=2"', and treating the extra words as URLs to download.
Spell out the splitting rule, point to curl's '--config' or to using curl directly for arguments containing whitespace, and warn against building the value from untrusted input.
Thanks to Harry Sintonen for reporting the issue.