replication: replace deprecated volume_id with reserved field - #86
Merged
mergify[bot] merged 1 commit intoJul 14, 2026
Merged
Conversation
santhoshatdell
force-pushed
the
pvt/volume-id-reserved
branch
from
July 10, 2026 19:54
69ac7aa to
e0eb841
Compare
Madhu-1
previously approved these changes
Jul 13, 2026
There was a problem hiding this comment.
Pull request overview
This PR finalizes removal of the deprecated volume_id field (tag 1) from all replication request messages by replacing it with reserved 1, ensuring the generated Go types no longer expose GetVolumeId() and avoiding downstream validators rejecting requests that intentionally rely on replication_source.
Changes:
- Replaced deprecated
volume_id = 1withreserved 1across all replication request messages inreplication.proto. - Updated the replication README’s protobuf snippets to match the updated message definitions.
- Regenerated Go protobuf output so the request types no longer include
VolumeIdfields /GetVolumeId()getters.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 12 comments.
| File | Description |
|---|---|
| replication/replication.proto | Removes deprecated volume_id fields from replication request messages via reserved 1. |
| replication/README.md | Updates documented protobuf message definitions to match the proto changes. |
| lib/go/replication/replication.pb.go | Regenerated Go protobuf output reflecting the field removals (request structs no longer have GetVolumeId()). |
Files not reviewed (1)
- lib/go/replication/replication.pb.go: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The volume_id field (field number 1) in all replication request messages was deprecated in favor of replication_source. Replace the deprecated field declaration with `reserved 1` to fully remove it from the generated Go code. This prevents validation middleware (e.g. gocsi spec validator) from rejecting replication RPCs due to an empty volume_id field, which is the expected state when using the newer replication_source field. Fixes: #85 Signed-off-by: Santhosh Lakshmanan <Santhosh.Lakshmanan@dell.com>
santhoshatdell
force-pushed
the
pvt/volume-id-reserved
branch
from
July 13, 2026 18:00
e0eb841 to
e865290
Compare
Madhu-1
approved these changes
Jul 14, 2026
Merge Queue Status
This pull request spent 2 minutes 52 seconds in the queue, including 2 minutes 35 seconds running CI. Required conditions to merge
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The volume_id field (field number 1) in all replication request messages was deprecated in favor of replication_source. Replace the deprecated field declaration with
reserved 1to fully remove it from the generated Go code.This prevents validation middleware (e.g. gocsi spec validator) from rejecting replication RPCs due to an empty volume_id field, which is the expected state when using the newer replication_source field.
Fixes: #85