Skip to content

house-keeping - #26

Merged
csboo merged 14 commits into
mainfrom
repo-state
Mar 24, 2026
Merged

house-keeping#26
csboo merged 14 commits into
mainfrom
repo-state

Conversation

@jarjk

@jarjk jarjk commented Mar 21, 2026

Copy link
Copy Markdown
Collaborator

fixes #5

adds readme, fish mock client, .env.example, very-very basic home-page

takes some weight off #4

@jarjk
jarjk force-pushed the repo-state branch 4 times, most recently from 4fcf2eb to 77a5a68 Compare March 21, 2026 20:25
@jarjk

jarjk commented Mar 21, 2026

Copy link
Copy Markdown
Collaborator Author

TODOs:

  • should we add dx check to ci?
  • ci should make use of Makefile
  • add check, format option to Makefile

@jarjk
jarjk requested a review from csboo March 21, 2026 23:36
@jarjk
jarjk marked this pull request as draft March 22, 2026 12:32
@jarjk jarjk changed the title basic repo-stuff house-keeping Mar 22, 2026
Comment thread AGENTS.md

@csboo csboo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work you put into this!

I mostly agree with the changes, good stuff..

I would remove the agents file as said before merging.

@csboo

csboo commented Mar 22, 2026

Copy link
Copy Markdown
Owner

I'm not sure about the fish client either,
I don't know fish scripts that well, but it surely needs at least fish to be able to be ran, which nothing else needs.

i wouldn't suppose changing it to anything else though.

Surely the best solution would be to write a proper seeder into the backend itself with a feature maybe.

For now it is fine, but I'm not sure if it should be merged into main since it doesn't have much to do with the project.

What do you think about this? @jarjk

@jarjk

jarjk commented Mar 22, 2026

Copy link
Copy Markdown
Collaborator Author

I'm not sure about the fish client either, I don't know fish scripts that well, but it surely needs at least fish to be able to be ran, which nothing else needs.

i wouldn't suppose changing it to anything else though.

Surely the best solution would be to write a proper seeder into the backend itself with a feature maybe.

For now it is fine, but I'm not sure if it should be merged into main since it doesn't have much to do with the project.

What do you think about this? @jarjk

"For now it is fine, but I'm not sure if it should be merged into main since it doesn't have much to do with the project."

what's the "for now" in here? while the PR is in draft, or what? on the other hand, it enables you to use the project in it's current state, which means it does have something to do with it

it's definitely useful to have some kind of a client to be able to set up the server properly before having an actual client

I agree fish isn't the most useful language here, I'd though it's good for reference, python would actually make sense here I think (windows support, availability, ...)

building an actual client in rust without #22 is painful and definitely not worth the time

what do you say? I'll vibe a python client to see how bad it is though

@csboo

csboo commented Mar 22, 2026

Copy link
Copy Markdown
Owner

"for now" is until we find a better solution, and (as you yourself answered) that would involve many things like #22 ...

@csboo

csboo commented Mar 22, 2026

Copy link
Copy Markdown
Owner

it enables you to use the project in it's current state, which means it does have something to do with it

its not the fish script that enables you to use the project, at the very least nothing stops you to run curls by hand and you dont even need fish for it, and its even cross platform

it's definitely useful to have some kind of a client to be able to set up the server properly before having an actual client

yeah but thats already wip, while there isnt an actual client that does that, this could stay in an issue and be just copy pasted there as a basic solution or sth

I agree fish isn't the most useful language here, I'd though it's good for reference, python would actually make sense here I think (windows support, availability, ...)

i dont think that would make much of a difference, who used windows anyways

@jarjk

jarjk commented Mar 22, 2026

Copy link
Copy Markdown
Collaborator Author

i see, that clears things up

@jarjk
jarjk force-pushed the repo-state branch 7 times, most recently from 7858539 to a9677da Compare March 23, 2026 18:49
@jarjk
jarjk marked this pull request as ready for review March 23, 2026 19:00
@jarjk
jarjk requested a review from csboo March 23, 2026 19:35

@csboo csboo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look quite nice!
Great changes

@csboo
csboo merged commit 23d6ab4 into main Mar 24, 2026
7 checks passed
@jarjk jarjk mentioned this pull request Mar 24, 2026
@jarjk
jarjk deleted the repo-state branch April 12, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

readme

2 participants