Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Both new range types need TypeScript declarations that match their serialized WASM object representations.
2 open issues
What changed in this PR
Adds universal (all) and empty (none) VERS ranges, integrating them into the existing dynamic range API.
Changes:
- Introduces wildcard-only range types with constant membership results.
- Shares validation and serialization logic between both schemes.
- Extends dynamic parsing, serialization, TypeScript unions, and tests.
| File | Description |
|---|---|
src/schemes/none.rs |
Implements the empty range and validation tests. |
src/schemes/mod.rs |
Exposes both new scheme modules. |
src/schemes/all.rs |
Implements the universal range and validation tests. |
src/range/wildcard.rs |
Shares wildcard validation, constraints, and serialization. |
src/range/mod.rs |
Registers the internal wildcard helper module. |
src/range/dynamic.rs |
Integrates both schemes into dynamic operations and tests. |
Review effort: Balanced
# Conflicts: # src/range/dynamic.rs
tziemek
requested changes
Oct 28, 2026
peinjoh
commented
Oct 30, 2026
There was a problem hiding this comment.
🟡 Changes recommended
Universal and empty ranges have incorrect membership semantics, generated TypeScript declarations reference undefined types, and parsing and deserialization accept constraints that produce invalid range strings.
4 open issues
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.