Skip to content

Fix #108: Fix file ownership on Haiku after rsync#134

Merged
jacob-carlborg merged 2 commits into
cross-platform-actions:masterfrom
mr-raj12:fix/108-haiku-file-ownership
Apr 8, 2026
Merged

Fix #108: Fix file ownership on Haiku after rsync#134
jacob-carlborg merged 2 commits into
cross-platform-actions:masterfrom
mr-raj12:fix/108-haiku-file-ownership

Conversation

@mr-raj12
Copy link
Copy Markdown
Contributor

@mr-raj12 mr-raj12 commented Apr 6, 2026

rsync -auz preserves numeric UIDs. On the Linux runner files are owned by uid 1001, inside the Haiku VM the user is uid 0.
Git 2.35.2+ won't run in a directory owned by a different user.
The mismatch was always there, just never triggered. setuptools 78.1.1 calls setuptools_scm earlier in pip install -e . than older versions did, so git gets invoked during install and hits the check for the first time.

Fix adds a synchronizePaths override in the Haiku VM to run chown after rsync as same pattern as the existing setupWorkDirectory override in the same file, no other OS touched.

Adds a CI job test-haiku-file-ownership that boots Haiku and asserts find . -nouser returns nothing verifying no files in the work directory are owned by an unresolvable uid after rsync.

@manxorist identified the issue and proposed the chown approach in #108, this is just the implementation.

borgbackup/borg#9563 worked around it with
git config --global --add safe.directory on their end, which is how we ran into this.

Closes #108

Comment thread src/operating_systems/haiku/qemu_vm.ts
@jacob-carlborg
Copy link
Copy Markdown
Contributor

I would prefer an end-to-end test as well, to make sure it's working properly. A new job in the GitHub action workflow, something like:

test-cpu-count-config:
.

@manxorist
Copy link
Copy Markdown

As mentioned in #108 (comment), another option might be to tweak the rsync parameters, but I have not looked at that at all.

@jacob-carlborg jacob-carlborg merged commit db3b320 into cross-platform-actions:master Apr 8, 2026
94 checks passed
@jacob-carlborg
Copy link
Copy Markdown
Contributor

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wrong file permissions on Haiku

3 participants