UX backlog: gate Ctrl+Enter behind the tour, reduced-motion-aware entrance#17
Merged
Conversation
…rance - Guided/Compose Ctrl+Enter copy handlers now no-op while a modal dialog is open — the app behind the tour is inert, so a copy fired from a window listener would be invisible to the user. Pinned by a test. - Tour entrance: 120ms backdrop fade + 160ms panel rise, CSS-only and gated on prefers-reduced-motion (instant dialog otherwise). 230 tests, typecheck, build green; animations verified live in dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small follow-ups from the PR #15 improvement backlog (this commit landed on the tour branch after #15/#16 were merged, so it needed its own PR):
window, so they fired even with the app inert behind the dialog: an invisible clipboard write. They now no-op while a modal dialog is open (the tour is the app's onlyrole="dialog"). Pinned by a regression test.prefers-reduced-motion: no-preferenceso motion-sensitive users get an instant dialog. Verified live in dev (computed animation styles present in both elements).230 tests, typecheck, catalog check, production build all green.