Skip to content

Switch sqlalchemy-cratedb from dev branch to released 0.43.1 - #1867

Merged
bgunebakan merged 4 commits into
mainfrom
fix/update-sqlalchemy-cratedb-to-0.43.1
Jun 25, 2026
Merged

Switch sqlalchemy-cratedb from dev branch to released 0.43.1#1867
bgunebakan merged 4 commits into
mainfrom
fix/update-sqlalchemy-cratedb-to-0.43.1

Conversation

@bgunebakan

@bgunebakan bgunebakan commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary of the changes / Why this is an improvement

The SQLAlchemy and pandas nightly CI jobs were failing with:

    ParsingException[line 1:71: no viable alternative at input
      'SELECT table_name FROM information_schema.tables WHERE table_schema = %']

Both examples were pinned to the amo/postgresql-async dev branch of sqlalchemy-cratedb, which adds a _format_query helper that rewrites ? placeholders to %s when the dialect's paramstyle is pyformat. This branch is old and does not have features that used in current package.

This update will fix the pipeline and will help to test with latest packages.

Checklist

  • Link to issue this PR refers to (if applicable): Fixes #???

@bgunebakan bgunebakan self-assigned this Jun 24, 2026
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7761eaad-0d32-44fd-a6be-79e31a15ad09

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/update-sqlalchemy-cratedb-to-0.43.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bgunebakan
bgunebakan requested review from florinutz and kneth June 24, 2026 13:53
@amotl

amotl commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Hi Bilal. Thank you. This patch roughly looks like a duplicate of this other one?

Comment on lines 10 to +18
def test_insert_efficient_multirow():
insert_records = 25_000
# CrateDB enforces statement_max_length=262144; keep well under that limit.
insert_records = 5_000
cmd = f"time python insert_efficient.py cratedb multirow {insert_records}"
run(cmd)


def test_insert_efficient_batched():
insert_records = 50_000
insert_records = 5_000

@amotl amotl Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this. I've seen the same thing, and it might be a huge red flag against the recent change in crate-python, so we might not want to have this slip unnoticed? In GH-1839, I am deliberately using crate>=2.1.2,<2.2 and sqlalchemy-cratedb[all]<0.43, in order to surface this discovery on behalf of a later PR and flag it for review more prominently.

I think the change is significant for some users who use the manyrows marshalling style (default with pandas), as it will decrease available bulk sizes in standard communication paths with CrateDB by a huge factor.

In this spirit, I was planning two phases here:
a) Restore compatibility (phase out experimental features) with GH-1839.
b) Surface the bulk size regression with a later patch that upgrades package versions.
c) Present the regression to other colleagues.

wdyt?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are tracking this observation here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explained details about this on the related issue page, This is not a bug so there is nothing to do. Just adjusting example codes are enough. Thanks.

@bgunebakan
bgunebakan merged commit 7b76ba7 into main Jun 25, 2026
5 checks passed
@bgunebakan
bgunebakan deleted the fix/update-sqlalchemy-cratedb-to-0.43.1 branch June 25, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants