[tweak_release_cycle_006] Use single quotes for empty qa_issue_url to pass prettier#638
Conversation
… pass prettier
## Summary
Prettier formats empty YAML strings with single quotes ('' not ""). The generator template used double quotes, so CI's prettier --check failed. Switch to single quotes and update the sed patterns in orchestrate-release-lock.sh that read and write qa_issue_url to handle both quote styles.
## Changes
- generate-release-testing-instructions.sh: qa_issue_url: "" → qa_issue_url: ''
- orchestrate-release-lock.sh: update the PRIOR_ISSUE_URL extraction sed and the QA_ISSUE_URL injection sed to match either single or double quotes
- tests/shell/*.bats: update all fixtures to use single quotes for the empty-string case
## Test Plan
- [x] Generated file passes prettier --check
- [x] All 194 bats tests pass
- [x] All 2060 unit tests pass
|
Warning Review limit reached
More reviews will be available in 12 minutes and 55 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ CI / Integration Tests (with overrides) — run summaryDuration: 1m 1s QA TC IDs: 2 exercised across 1 features Report: View run & artifacts Reproduce locally: Feature breakdown
|
✅ CI / Integration Tests (automated) — run summaryDuration: 11m 4s QA TC IDs: 161 exercised across 0 features Report: View run & artifacts Reproduce locally: Feature breakdown
|
✅ CI / Integration Tests (with extensions) — run summaryDuration: 12m 58s Unit tests: Ran in separate Test & Validate job QA TC IDs: 193 exercised across 25 features Report: View run & artifacts Reproduce locally: Feature breakdown
|
Summary
Prettier formats empty YAML strings with single quotes ('' not ""). The generator template used double quotes, so CI's prettier --check failed. Switch to single quotes and update the sed patterns in orchestrate-release-lock.sh that read and write qa_issue_url to handle both quote styles.
Changes
Test Plan