Skip to content

CBG-5500 remove unused UseXattrs/KvTLSPort from BucketSpec#8390

Open
torcolvin wants to merge 2 commits into
mainfrom
CBG-5500
Open

CBG-5500 remove unused UseXattrs/KvTLSPort from BucketSpec#8390
torcolvin wants to merge 2 commits into
mainfrom
CBG-5500

Conversation

@torcolvin

Copy link
Copy Markdown
Collaborator

CBG-5500 remove unused UseXattrs/KvTLSPort from BucketSpec

  • Update docs to indicate that KvTLSPort is unused, though it has been at least since gocb was used.
  • Remove unused option for UseXattrs, it was set by the REST package but unused.

This is part of a bigger removal process of the xattr code, but it is easier to do in easy to digest stages. I want to isolate test and non test PRs.

@torcolvin torcolvin requested a review from bbrks June 26, 2026 20:17
Copilot AI review requested due to automatic review settings June 26, 2026 20:17
@github-actions

Copy link
Copy Markdown

Redocly previews

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the xattr-mode cleanup by removing UseXattrs and KvTLSPort from base.BucketSpec (since they’re no longer used), and updates the OpenAPI schema to reflect the deprecation/ignored status of kv_tls_port.

Changes:

  • Removed UseXattrs and KvTLSPort from base.BucketSpec and eliminated related plumbing in REST/config/test code.
  • Removed the BucketSpec-level xattrs feature gate (previously driven by BucketSpec.UseXattrs).
  • Updated OpenAPI schema to move kv_tls_port into the deprecated section and clarify it is ignored.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
rest/server_context.go Stops populating BucketSpec.UseXattrs (and removes related warning) during bucket spec creation.
rest/server_context_test.go Removes KvTLSPort propagation from test bucket config helpers.
rest/config.go Stops mapping kv_tls_port into base.BucketSpec in MakeBucketSpec.
docs/api/components/schemas.yaml Marks kv_tls_port as deprecated/ignored in the OpenAPI schema and relocates it accordingly.
base/main_test_bucket_pool_util.go Removes UseXattrs from test bucket spec creation.
base/leaky_datastore.go Removes UseXattrs from the minimal BucketSpec returned by LeakyDataStore.GetSpec().
base/bucket.go Removes UseXattrs/KvTLSPort fields and the UseXattrs-driven xattrs support check from GetBucket.
Comments suppressed due to low confidence (1)

rest/server_context.go:692

  • kv_tls_port is now documented as ignored and is no longer propagated into base.BucketSpec, but GetBucketSpec will still silently accept a non-default kv_tls_port value. Consider logging a warning when a non-default port is configured so users don’t assume it’s being honored (especially during upgrades).

	if config.BucketOpTimeoutMs != nil {
		operationTimeout := time.Millisecond * time.Duration(*config.BucketOpTimeoutMs)
		spec.BucketOpTimeout = &operationTimeout
	}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants