Conversation
Redocly previews |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the xattr-mode cleanup by removing UseXattrs and KvTLSPort from base.BucketSpec (since they’re no longer used), and updates the OpenAPI schema to reflect the deprecation/ignored status of kv_tls_port.
Changes:
- Removed
UseXattrsandKvTLSPortfrombase.BucketSpecand eliminated related plumbing in REST/config/test code. - Removed the
BucketSpec-level xattrs feature gate (previously driven byBucketSpec.UseXattrs). - Updated OpenAPI schema to move
kv_tls_portinto the deprecated section and clarify it is ignored.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rest/server_context.go | Stops populating BucketSpec.UseXattrs (and removes related warning) during bucket spec creation. |
| rest/server_context_test.go | Removes KvTLSPort propagation from test bucket config helpers. |
| rest/config.go | Stops mapping kv_tls_port into base.BucketSpec in MakeBucketSpec. |
| docs/api/components/schemas.yaml | Marks kv_tls_port as deprecated/ignored in the OpenAPI schema and relocates it accordingly. |
| base/main_test_bucket_pool_util.go | Removes UseXattrs from test bucket spec creation. |
| base/leaky_datastore.go | Removes UseXattrs from the minimal BucketSpec returned by LeakyDataStore.GetSpec(). |
| base/bucket.go | Removes UseXattrs/KvTLSPort fields and the UseXattrs-driven xattrs support check from GetBucket. |
Comments suppressed due to low confidence (1)
rest/server_context.go:692
kv_tls_portis now documented as ignored and is no longer propagated intobase.BucketSpec, butGetBucketSpecwill still silently accept a non-defaultkv_tls_portvalue. Consider logging a warning when a non-default port is configured so users don’t assume it’s being honored (especially during upgrades).
if config.BucketOpTimeoutMs != nil {
operationTimeout := time.Millisecond * time.Duration(*config.BucketOpTimeoutMs)
spec.BucketOpTimeout = &operationTimeout
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBG-5500 remove unused UseXattrs/KvTLSPort from BucketSpec
UseXattrs, it was set by the REST package but unused.This is part of a bigger removal process of the xattr code, but it is easier to do in easy to digest stages. I want to isolate test and non test PRs.