CBG-5480 make sure pre-commit run --all-files passes#8389
Merged
Conversation
bbrks
approved these changes
Jun 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure pre-commit run --all-files succeeds by aligning a repo tool script with the configured Python formatting expectations and by excluding RPM-macro template files from ShellCheck scanning.
Changes:
- Reformat
tools/manifest-helperto satisfy pre-commit’s Python formatting. - Update ShellCheck exclusions in
.pre-commit-config.yamlto skipbuild/postinst.tmplandbuild/postrm.tmpl.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/manifest-helper | Auto-formatting changes; needs a small fix to keep revision comparisons correct under Python 3. |
| .pre-commit-config.yaml | Excludes RPM macro template files from the ShellCheck hook so pre-commit can run cleanly. |
Comment on lines
+150
to
151
| latest_commit = subprocess.check_output(["git", "rev-parse", "HEAD"], cwd=path) | ||
| return latest_commit.strip() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBG-5480 make sure pre-commit run --all-files passes
manifest_helperas python and autoformatted itbuild/postinst.tmplandbuildpostrm.tmplwhich have rpm macro expansion in them