Allow for more info to be retrued on catalog entities data source - #101
Merged
mmaikel merged 3 commits intoJun 29, 2026
Merged
Conversation
TomWKraken
force-pushed
the
allow-info-request-catalog-entities
branch
from
June 18, 2026 13:29
cb47623 to
3a00b92
Compare
mmaikel
self-requested a review
June 23, 2026 14:48
mmaikel
reviewed
Jun 23, 2026
mmaikel
left a comment
Contributor
There was a problem hiding this comment.
Looks solid to me.
I'd just suggest adding some test coverage on the provider mapping layer (internal/provider/) because the Read() flattening that builds ownership.groups[] from owners.teams[] is actually the new logic here. Not a big deal, though. Apart from that, a question about the individual owners being ignored.
mmaikel
self-requested a review
June 29, 2026 16:15
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, in order to use a catalog entities ownerhsip and Git information, a follow up call per entity was required. This change allows us to retrieve that information from the single paginated "Entities" data source.
The Git information was returned by default any way by the API call, so this change just surfaces that information.
The owners info was not previously retrieved and requires adding a param to the API call so this has been added as a toggle to the data source.
The following test code was used in order to verify the behaviour: