[NT-2874] iOS parity with RN and centralization of preview panel logic#236
Open
Alex Freas (akfreas) wants to merge 46 commits intomainfrom
Open
[NT-2874] iOS parity with RN and centralization of preview panel logic#236Alex Freas (akfreas) wants to merge 46 commits intomainfrom
Alex Freas (akfreas) wants to merge 46 commits intomainfrom
Conversation
…de across platforms
Alex Freas (akfreas)
requested review from
Lotfi Anwar L Arif (Lotfi-Arif) and
Charles Hudson (phobetron)
as code owners
…thin usePreviewData to a useMemo wrapper
…ewModel via getPreviewState
…licated entry mappers
…PreviewOverrideManager
…or DTO consistency
… and override state
… panel overrides reach OptimizedEntry
Alex Freas (akfreas)
changed the title
…mization-preview package
Alex Freas (akfreas)
changed the title
…#242) * feat: update env var handling in dev harness * feat: add new sections for flags, Lifecycle, tracking * feat: update app with new sections * feat: add better handling for destroying the Web SDK instance and release runtime resources. * feat: add launch scripts for the react dev harness and ref implementation * revert: remove accidental iOS bridge file change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves functionality critical to the preview panel implementations into a new
preview-sdkso that it can be shared between React Native and the JSCore implementations (iOS and Android). This allows us to keep a single implementation of the override and interceptor logic for all platforms.