Repository navigation
Conversation
Signed-off-by: Cristian Filipescu <filipescu.cristian@gmail.com>
Signed-off-by: Cristian Filipescu <filipescu.cristian@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compose configurations that request a fixed restart delay currently fail with
deploy is not supported, requiring a separate systemd override alongside generated Quadlets.Convert
deploy.restart_policy.conditionanddelayinto[Service]Restart=andRestartSec=. The deployment policy takes precedence over the service-levelrestartfield, with Compose defaults ofcondition: anyanddelay: 0s. Existingrestartconversion stays unchanged when no deployment policy is present. Both standalone and--podQuadlet output use the conversion.Also expose
--restart-sec DURATIONfor Podman command conversion. Keep unsupportedmax_attempts,window, extensions, and other deployment settings as errors so they are not silently ignored.For example:
now includes:
CI compatibility: Rust 1.99.1 reports trailing-semicolon macro errors for three existing
bail!match arms. A separate follow-up commit places those calls in statement blocks without changing their behavior.Validation:
cargo +1.99.1 fmt --checkcargo +1.99.1 test --locked— 87 passedcargo +1.99.1 clippy --locked -- -D warningscargo build --lockedRestart=alwaysandRestartSec=5sin the installed Quadlet generator's output.