KSQL-14984: demote client-side request failures from ERROR to DEBUG/WARN - #11044
Open
Parag Badani (pbadani) wants to merge 2 commits into
Open
KSQL-14984: demote client-side request failures from ERROR to DEBUG/WARN#11044Parag Badani (pbadani) wants to merge 2 commits into
Parag Badani (pbadani) wants to merge 2 commits into
Conversation
In ksql prod, ~5.9M of 9.4M daily ERROR log entries (~63%) are client-side request failures with no server-side action available: 4xx responses logged by FailureHandler, SNI mismatches from misconfigured clients, SSL/Netty handshake failures from port scanners and Kafka-protocol traffic hitting the HTTPS endpoint, and access-log lines for boot-time 503s and probe traffic. Demote these to DEBUG/WARN so the error log reflects genuine server-side problems that operators can act on. Genuine 5xx exceptions in FailureHandler remain at ERROR; HAProxyProtocolException and unrecognised throwables in the Vert.x exception handler remain at ERROR. Also dedupe ServerVerticle.unhandledExceptionHandler by delegating to ApiServerUtils.unhandledExceptionHandler (the two were identical copies). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
NotSslRecordException and SslHandshakeTimeoutException both extend javax.net.ssl.SSLException, so the SSLException check already covers them. Drops the redundant instanceof branches to satisfy the checkstyle limit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reduce the redundant logs
Linked: KSQL-14984.
Test plan
mvn -pl ksqldb-rest-app test -Dtest='LoggingHandlerTest,SniHandlerTest,ApiServerUtilsTest'— 30/30 passingmvn -pl ksqldb-rest-app checkstyle:check— clean🤖 Generated with Claude Code