Two reentrancy-guard mechanisms coexist in the stream contract

[Jaydbrown]

state::acquire/release/with_guard (depth-counter at DataKey::Guard) is the real guard. A merged PR also left storage::read_guard/write_guard plus GUARD_NOT_ENTERED/GUARD_ENTERED constants that nothing calls. Delete the unused pair so there's one guard API.

[ZacLou]

I'd like to work on this issue. I have relevant experience with this tech stack and can deliver a clean, well-tested PR. I can submit within 1-2 days.

[ZacLou]

I looked into this and the unused storage::read_guard / write_guard pair and
GUARD_NOT_ENTERED / GUARD_ENTERED constants no longer exist on main.
The only reentrancy guard left is state::acquire / release / with_guard using DataKey::Guard.

It appears this cleanup has already landed, so this issue may be safe to close.
If there is still work remaining, happy to open a PR — just let me know.

[Ranjeet2063]

Hi maintainers, I would love to be assigned to this issue.

I am an active core contributor in the Stellar/Soroban ecosystem (#1 contributor on Mova Store with 28 successfully merged PRs), with deep expertise across Soroban SDK smart contracts, cryptographic access controls, and production test suites.

🎯 Technical Execution Plan for Two reentrancy-guard mechanisms coexist in the stream contract:

1. Module & Storage Analysis: Pinpoint the exact contract modules in conduit-protocol/streamFi-contracts handling this logic. Define explicit storage DataKeys, TTL policies, and auth boundaries (require_auth()).
2. Canonical Soroban Implementation: Implement the required state changes, validations, and structured event emissions (env.events().publish(...)) adhering strictly to official Soroban best practices and zero arithmetic overflow/underflow.
3. Exhaustive Unit Test Suite: Build comprehensive tests covering:
   • Happy-path state transitions and expected outputs.
   • Boundary limits, edge cases, and zero/saturating values.
   • Negative tests asserting unauthorized callers (mock_auths(&[])) and invalid parameter reverts with exact ContractError variants.
4. CI & Verification Gate: Verify 100% clean cargo check, zero clippy warnings, and full test suite passing locally before opening the PR.

💡 Why Assigning Me Directly Benefits You:

• Zero Maintainer Overhead: Self-documenting code with exhaustive tests so you don't spend valuable time babysitting, debugging, or fixing CI.
• Fast Issue Closure: Production-grade PR delivered in 12–24h, cleanly clearing this issue off your backlog.
• Proven Reliability: 28 merged PRs as #1 contributor on Mova Store — guaranteed senior-level execution from day one.

[Fading-Dev]

Hello! I’d be glad to work on this. The issue presents a good opportunity to improve the project, and I’m confident I can deliver the requested functionality while keeping the existing behavior intact. I’ll validate everything before opening the PR.

[shobhamerabacha-star]

Hello! I'd like to work on this issue.

I would love to take this on. My planned approach:

• Implement Two reentrancy-guard mechanisms coexist in the stream contract with explicit require_auth checks, clean storage layouts, and robust Soroban contract logic.
• Add comprehensive unit tests verifying both happy-path invocations and unauthorized revert scenarios.

Excited to work on this—please assign to me and I'll submit a clean PR shortly!

[ranjeet150]

Hello @maintainers,

I would like to resolve this issue. Here is my proposed execution plan:

• Implementation: Implement Two reentrancy-guard mechanisms coexist in the stream contract with explicit require_auth checks, clean storage layouts, and robust Soroban contract logic.
• Testing & Verification: Add comprehensive unit tests verifying both happy-path invocations and unauthorized revert scenarios.
• Delivery: Ready to ship a thoroughly tested PR within 12–24 hours with passing CI.

Looking forward to contributing—please feel free to assign!

[guptakumarranjeet150]

Hi maintainers,

I would love to take this on. My planned approach:

• Implement Two reentrancy-guard mechanisms coexist in the stream contract with explicit require_auth checks, clean storage layouts, and robust Soroban contract logic.
• Add comprehensive unit tests verifying both happy-path invocations and unauthorized revert scenarios.

Happy to pick this up today—please assign to me!

[Adesam007-pr3dator]

@Adesam007-pr3dator has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

Hi, I would love to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Adesam007-pr3dator to this issue.

[TheCodingChef-eth]

@TheCodingChef-eth has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

Hello maintainer, I can handle this issue.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @TheCodingChef-eth to this issue.

[drips-wave]

Congratulations, @TheCodingChef-eth! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on September 30, 2026.

🧑‍💻 @TheCodingChef-eth: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been completed by @TheCodingChef-eth as part of the Stellar Wave Program's 9th Wave 🥳

😎 @TheCodingChef-eth: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.