Skip to content

main has no branch protection; broken code can merge #434

Description

@Jaydbrown

PR #373 merged a non-compiling contracts/stream/src/storage.rs (mangled attributes, use soroban_sdk:{;, a typo'd FLAG_ClAWBACK_ENABLED). main should require the Build WASM, Lint and Test checks to pass before merge, and disallow force-push. Right now a red PR can be merged with admin override and nobody notices until the next PR's CI fails.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programbugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions