Assignment 02 - Italic E robot#18
Open
Grangeot wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Paste a screenshot of the solution whenever possible (
ctrl+vorcmd+vdirectly on this textbox works)Add optional notes/remarks to be taken into account for evaluating the submission
I'm still not totally familiar with Python and how to make code cleaner (for example, in
model.add_joint, I specified again 5 times the type of joint). Advices are gladly appreciated :)Also, I'm not sure I understand if both
model.compute_transformations(configuration)ANDartist.update(configuration)are both required, I still don't grasp the extent of the artist.But thanks for the learning experience ! Definetly great for me.
Since I wanted to understand 100% what I'm doing, I did not do the assignment with a teammate, despite my registration on the spreadsheet. I hope it's ok.
Thanks again.