feat: share dialog, SharedMaps feature flag, publish toggle rename - #471
Open
joaquimds wants to merge 1 commit into
Open
feat: share dialog, SharedMaps feature flag, publish toggle rename#471joaquimds wants to merge 1 commit into
joaquimds wants to merge 1 commit into
Conversation
Stage 6 (final) of the read-only private maps feature (plan in READ_ONLY_PRIVATE_MAPS.md): - ShareMapDialog: Share button + popover in the private map navbar — enable/disable the read-only link, set/change/remove the optional password, copy the link, and reset it (invalidating the old URL) - New Feature.SharedMaps organisation flag gating the Share button (dev mode enables all flags, as with the existing ones) - MapModeToggle "Share" label renamed to "Publish", freeing "share" for the new read-only link feature; both navbars use the same component so one rename covers the editor and publish modes Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The final piece of read-only private map sharing — stage 6 of the plan in
READ_ONLY_PRIVATE_MAPS.md, completing the feature started in #468 (backend) and #469 (viewer + password gate). Adds the owner-facing controls: the Share button and dialog, theFeature.SharedMapsorganisation flag, and the toggle rename that frees the word "share" for this feature.What's included
ShareMapDialog— a Share button in the private map navbar opening a popover:passwordUpdatedAt.All state flows through the
mapSharetRPC router from #468; mutations return the fresh share state, which is written straight into the query cache (no refetches).Feature.SharedMaps— new organisation feature flag gating the Share button, following theFeature.PublicMapsprecedent. As with all flags, development mode enables it unconditionally. The/share/[token]route itself is not flag-gated, so existing links keep working if an org's flag is later turned off (per the plan's open-question resolution).Toggle rename —
MapModeToggle's "Share" tab is now "Publish". Both the editor and publish-mode navbars render the same component, so the single rename covers both. Copy audit found no other user-facing text calling publishing "share" (the "Shared Care Agreement" strings in the publish constants are domain data, not UI copy).Test plan
npm run lintclean (prettier, eslint, tsc, madge)Notes for reviewers
grants_revoked_atcolumn is the clean follow-up.🤖 Generated with Claude Code