Conversation
Almost all car implementations are setting CarState.brake incorrectly by either: * not setting it * setting it to 0 * setting it to an int value having arbitrary units (the field is a float fraction) This is a defunct field that openpilot no longer uses. (It does use brakePressed.)
Car behavior reportReplays driving segments through this PR and compares the behavior to master. Testing 742 segments for: CHRYSLER_PACIFICA_2018_HYBRID, CHRYSLER_PACIFICA_2019_HYBRID, CHRYSLER_PACIFICA_2018, CHRYSLER_PACIFICA_2020, FORD_BRONCO_SPORT_MK1, FORD_ESCAPE_MK4, FORD_ESCAPE_MK4_5, FORD_EXPLORER_MK6, FORD_F_150_MK14, FORD_F_150_LIGHTNING_MK1, FORD_FOCUS_MK4, FORD_MAVERICK_MK1, FORD_MUSTANG_MACH_E_MK1, FORD_RANGER_MK2, GMC_ACADIA, GMC_YUKON, HONDA_ACCORD, HONDA_CIVIC_BOSCH, HONDA_CIVIC_2022, HONDA_CRV_5G, HONDA_CRV_HYBRID, HONDA_HRV_3G, HONDA_INSIGHT, HONDA_E, HONDA_PILOT_4G, HONDA_CRV, HONDA_FIT, HONDA_FREED, HONDA_HRV, HONDA_ODYSSEY, HONDA_PILOT, HONDA_RIDGELINE, HONDA_CIVIC, HYUNDAI_AZERA_HEV_6TH_GEN, HYUNDAI_ELANTRA_GT_I30, HYUNDAI_ELANTRA_2021, HYUNDAI_ELANTRA_HEV_2021, HYUNDAI_GENESIS, HYUNDAI_IONIQ, HYUNDAI_IONIQ_HEV_2022, HYUNDAI_IONIQ_EV_2020, HYUNDAI_IONIQ_PHEV_2019, HYUNDAI_IONIQ_PHEV, HYUNDAI_KONA_2022, HYUNDAI_KONA_EV, HYUNDAI_KONA_EV_2022, HYUNDAI_KONA_EV_2ND_GEN, HYUNDAI_SANTA_FE, HYUNDAI_SANTA_FE_2022, HYUNDAI_SANTA_FE_HEV_2022, HYUNDAI_SANTA_FE_PHEV_2022, HYUNDAI_SONATA, HYUNDAI_SONATA_LF, HYUNDAI_STARIA_4TH_GEN, HYUNDAI_PALISADE, HYUNDAI_SONATA_HYBRID, HYUNDAI_IONIQ_5, HYUNDAI_IONIQ_6, HYUNDAI_TUCSON_4TH_GEN, HYUNDAI_SANTA_CRUZ_1ST_GEN, HYUNDAI_CUSTIN_1ST_GEN, MAZDA_CX5, MAZDA_CX9_2021, MAZDA_CX5_2022, RIVIAN_R1, TESLA_MODEL_3, TESLA_MODEL_Y, VOLKSWAGEN_ARTEON_MK1, VOLKSWAGEN_ATLAS_MK1, VOLKSWAGEN_CRAFTER_MK2, VOLKSWAGEN_GOLF_MK7, VOLKSWAGEN_JETTA_MK7, VOLKSWAGEN_PASSAT_MK8, VOLKSWAGEN_PASSAT_NMS, VOLKSWAGEN_POLO_MK6, VOLKSWAGEN_TAOS_MK1, VOLKSWAGEN_TIGUAN_MK2, VOLKSWAGEN_TOURAN_MK2, VOLKSWAGEN_TRANSPORTER_T61, VOLKSWAGEN_TROC_MK1 Show changes |
Almost all car implementations are setting CarState.brake incorrectly by either:
This is a defunct field that openpilot (essentially) no longer uses. Prerequisite PR: commaai/openpilot#37857
Validation TODO