safety: split CAN ignition detection into per-mode hooks#3310
Open
adeebshihadeh wants to merge 6 commits intocommaai:masterfrom
Open
safety: split CAN ignition detection into per-mode hooks#3310adeebshihadeh wants to merge 6 commits intocommaai:masterfrom
adeebshihadeh wants to merge 6 commits intocommaai:masterfrom
Conversation
Contributor
Car behavior reportReplays driving segments through this PR and compares the behavior to master. Testing 67 segments for: GMC_ACADIA, GMC_YUKON, MAZDA_CX5, MAZDA_CX9_2021, MAZDA_CX5_2022, RIVIAN_R1, TESLA_MODEL_3, TESLA_MODEL_Y ✅ 0 changed, 67 passed, 0 errors |
adeebshihadeh
force-pushed
the
adeeb/move-can-ignition-hooks-1834
branch
3 times, most recently
from
9b2d387 to
2050c84
Compare
adeebshihadeh
force-pushed
the
adeeb/move-can-ignition-hooks-1834
branch
from
43fa2c6 to
f221c25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
goes with commaai/panda#2384