sign in: fix keyboard accessibility for all buttons#586
Open
star7js wants to merge 1 commit intocommaai:masterfrom
Open
sign in: fix keyboard accessibility for all buttons#586star7js wants to merge 1 commit intocommaai:masterfrom
star7js wants to merge 1 commit intocommaai:masterfrom
Conversation
- Apple sign-in and demo buttons used <a onClick> without href, making them unreachable via Tab key. Added href="#" and role="button" with preventDefault so they're keyboard-focusable. - Added focus-visible outline styling to sign-in buttons so keyboard users can see which button is focused. Fixes commaai#551
|
Welcome to connect! Make sure to:
deployed preview: https://586.connect-d5y.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<a onClick>withouthref, making them unreachable via Tab keyhref="#"withrole="button"andpreventDefaultso they're keyboard-focusable and behave correctlyfocus-visibleoutline styling to all sign-in buttons so keyboard users can see which button is focusedhrefand were unaffectedFixes #551