Skip to content

Audit can report no files when git ls-files fails #7

Description

@dajiaohuang

packages/cli/src/lib/audit.ts turns any nonzero git ls-files result, including a timeout, into an empty file list. packages/cli/src/commands/audit.ts then accepts that list and can return exit code 0 with “no files in scope of any edit-phase rule.” A failed enumeration can therefore look like a clean audit. Please report the audit as failed or incomplete when Git cannot list files. The focused regression belongs in packages/cli/test/audit.test.ts.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions