Repository navigation
fix(tui): show the session rename prompt once - #7054
Conversation
Pressing r in /sessions turns the picker's header into the rename field
("New title: ..._") and also set the status row under it to the same
"New title: " prompt, so the prompt sat on two rows, with an empty copy
under the one being typed into. Clear the status instead. The header
carries the prompt, and the status row is still there for the
title-length error and the "Renamed to" receipt.
Signed-off-by: Lstarsky0 <59827030+Lstarsky0@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…462) [skip ci] Existing Computer Use fixtures now exercise a genuine human card in both Ask and Full Access, retain forged-decision refusals in both, and reserve the autonomous refusal assertion for Auto and Never. This matches the production policy already in main; no trust-boundary behavior or new tests were added. Normalize existing core event enum formatting so cargo fmt passes. Move the ChatGPT originator fix into the latest release notes and record the founder-requested regular-browser verification. Real sign-in saved a verified grant, returned seven served models, and a tool-free gpt-6.1-sol request completed with the exact expected response. Synchronize the packaged changelog and credit the original PR #7054, merged separately as 57e726b. Verified: 19 existing Computer Use tests and 37 session-picker tests passed; fresh CLI build passed with all 4,136 source input hashes unchanged. The merged PR file is byte-identical to the input tested. Full cargo fmt check passed. Real CLI rename walkthrough passed at 60x24 and 140x40 with one prompt, empty title validation and saved-title confirmation. Dated-version, feature-note and contributor-credit checks passed after final documentation edits. Final tarball verification and exact-SHA hosted release gates remain pending.
|
Thanks @Lstarsky0 for finding the duplicated rename prompt and reducing it to the status line that repeated the header. Your PR is merged as 57e726bf3c, with your authorship and source branch preserved. I verified the exact patch in the fresh CLI at 60×24 and 140×40: one prompt, empty-title validation, and saved-title confirmation all behaved correctly; 37 existing session-picker tests passed. The unrelated Computer Use fixture failure you reported is corrected separately: Ask and Full Access both require the real human card, forged decisions remain rejected, and all 19 focused checks passed. This is in the 0.10.2 candidate; it is not published yet. |
What and why
Pressing
rin/sessionsshows the rename prompt twice. The header row turns into the input (New title: …_), and the key handler also sets the status row under it to the sameNew title:string. At 60×24, before:After:
Entering rename mode now clears the status instead. The header still carries the prompt, and the status row still shows
Title must be 1–100 charactersfor an empty title andRenamed to "…"afterwards. Search keeps its own status line, sinceSearch: type, Enter to applysays something the/…header doesn't.Issue
No-Issue: the /sessions rename prompt is shown twice; I searched and found no issue for it
How I tested it
/sessions,r, typed a title and pressed Enter, with this change and with a build ofmainfrom before it. The prompt rows above are from 60×24; theRenamed toreceipt is the same in both. Pressing Enter on an empty title still shows the length error.cargo check -p codewhale-tui --all-targetsandcargo +1.89.0 check -p codewhale-tui: clean. Merged onto currentmain(48fad09),cargo fmt --all -- --checkand CI's clippy forcodewhale-tuiare clean too.cargo nextest run -p codewhale-tui --libon that merge: 15361 passed, 1 failed, with thesession_pickertests among the passes. The failure iscomputer_use_autonomous_postures_block_before_the_plugin, which fails onmainwithout this change as well.Checklist
maincargo fmt --allpasses, and tests cover new or changed behaviordocs/features.toml(cargo test -p codewhale-tui --test feature_registrychecks it) — n/a