Skip to content

fix(tui): show the session rename prompt once - #7054

Merged
Hmbown merged 1 commit into
codewhale-hq:mainfrom
Lstarsky0:fix/session-rename-prompt-once
Oct 23, 2026
Merged

Hmbown merged 1 commit into
codewhale-hq:mainfrom
Lstarsky0:fix/session-rename-prompt-once

Conversation

@Lstarsky0

Copy link
Copy Markdown
Contributor

What and why

Pressing r in /sessions shows the rename prompt twice. The header row turns into the input (New title: …_), and the key handler also sets the status row under it to the same New title: string. At 60×24, before:

   New title: A much longer session title that will ... █
   New title:                                           █
   1. 4bf1eef0 | show default please | 2 msgs | curr... │

After:

   New title: A much longer session title that will n...
   1. 190a6040 | show default please | 2 msgs | curre...

Entering rename mode now clears the status instead. The header still carries the prompt, and the status row still shows Title must be 1–100 characters for an empty title and Renamed to "…" afterwards. Search keeps its own status line, since Search: type, Enter to apply says something the /… header doesn't.

Issue

No-Issue: the /sessions rename prompt is shown twice; I searched and found no issue for it

How I tested it

  • Ran a debug build in a pseudo-terminal with an empty HOME against a local OpenAI-compatible mock, sent one message so a session exists, then /sessions, r, typed a title and pressed Enter, with this change and with a build of main from before it. The prompt rows above are from 60×24; the Renamed to receipt is the same in both. Pressing Enter on an empty title still shows the length error.
  • cargo check -p codewhale-tui --all-targets and cargo +1.89.0 check -p codewhale-tui: clean. Merged onto current main (48fad09), cargo fmt --all -- --check and CI's clippy for codewhale-tui are clean too.
  • cargo nextest run -p codewhale-tui --lib on that merge: 15361 passed, 1 failed, with the session_picker tests among the passes. The failure is computer_use_autonomous_postures_block_before_the_plugin, which fails on main without this change as well.

Checklist

  • One focused change, on 3cb4cd2; it merges cleanly into current main
  • cargo fmt --all passes, and tests cover new or changed behavior
  • If this adds or changes a user-facing feature, I updated its docs and its row in docs/features.toml (cargo test -p codewhale-tui --test feature_registry checks it) — n/a

Pressing r in /sessions turns the picker's header into the rename field
("New title: ..._") and also set the status row under it to the same
"New title: " prompt, so the prompt sat on two rows, with an empty copy
under the one being typed into. Clear the status instead. The header
carries the prompt, and the status row is still there for the
title-length error and the "Renamed to" receipt.

Signed-off-by: Lstarsky0 <59827030+Lstarsky0@users.noreply.github.com>
@Lstarsky0
Lstarsky0 requested a review from Hmbown as a code owner October 22, 2026 22:50

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-actions github-actions Bot added the contribution-gate Author not yet in .github/APPROVED_CONTRIBUTORS; a maintainer grants access with /lgtm label Oct 22, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T22:52:14.096758Z f36ca36 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Hmbown
Hmbown merged commit 57e726b into codewhale-hq:main Oct 23, 2026
24 of 25 checks passed
Hmbown pushed a commit that referenced this pull request Oct 23, 2026
…462) [skip ci]

Existing Computer Use fixtures now exercise a genuine human card in both Ask
and Full Access, retain forged-decision refusals in both, and reserve the
autonomous refusal assertion for Auto and Never. This matches the production
policy already in main; no trust-boundary behavior or new tests were added.
Normalize existing core event enum formatting so cargo fmt passes.

Move the ChatGPT originator fix into the latest release notes and record the
founder-requested regular-browser verification. Real sign-in saved a verified
grant, returned seven served models, and a tool-free gpt-6.1-sol request
completed with the exact expected response. Synchronize the packaged changelog
and credit the original PR #7054, merged separately as 57e726b.

Verified: 19 existing Computer Use tests and 37 session-picker tests passed;
fresh CLI build passed with all 4,136 source input hashes unchanged. The merged
PR file is byte-identical to the input tested. Full cargo fmt check passed.
Real CLI rename walkthrough passed at 60x24 and 140x40 with one prompt, empty
title validation and saved-title confirmation. Dated-version, feature-note and
contributor-credit checks passed after final documentation edits.

Final tarball verification and exact-SHA hosted release gates remain pending.

Hmbown commented Oct 23, 2026

Copy link
Copy Markdown
Collaborator

Thanks @Lstarsky0 for finding the duplicated rename prompt and reducing it to the status line that repeated the header. Your PR is merged as 57e726bf3c, with your authorship and source branch preserved. I verified the exact patch in the fresh CLI at 60×24 and 140×40: one prompt, empty-title validation, and saved-title confirmation all behaved correctly; 37 existing session-picker tests passed. The unrelated Computer Use fixture failure you reported is corrected separately: Ask and Full Access both require the real human card, forged decisions remain rejected, and all 19 focused checks passed. This is in the 0.10.2 candidate; it is not published yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution-gate Author not yet in .github/APPROVED_CONTRIBUTORS; a maintainer grants access with /lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants