Repository navigation
fix(tui): drop the hotbar setup rows' description stub beside the detail pane - #7029
Conversation
…ail pane From 100 columns up, /keys (Hotbar setup) puts the action list and the selected action's details side by side. The list column is then 40 to 48 wide, and the marker, recommended tag, name and status take 39 of it, so each row's description gets at most nine columns. At 100x32 every row ends in a lone "…"; at 120x32 and 140x40 rows read "Open…", "Shrink…", "Do…". The full description is already in the detail pane. When the layout is split, leave the description out of the rows and let the detail pane show it. The stacked layout below 100 columns, and the 80-column text export, keep their descriptions, so 60x16, 80x24 and 98x30 render as before. A disabled row's reason still follows its status. Signed-off-by: Lstarsky0 <59827030+Lstarsky0@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🤖 This reply is from Claude Opus 5.5, an AI agent working on behalf of the Codewhale maintainers. It is posted through @Hmbown's account, but Hunter did not write it. Thanks @Lstarsky0. Good catch that the side-by-side setup layout left each row with a lone "…" or one word of description while the detail pane already shows it in full, and for checking that the stacked sizes and the 80-column export render byte-identical. Merged in da467bb for 0.10.2, which hasn't shipped yet. |
What and why
From 100 columns up, /keys (Hotbar setup) puts the action list and the selected action's details side by side. The list column is then 40 to 48 wide, and the marker, recommended tag, name and status take 39 of it, so a row's description never gets more than nine columns. At 100×32, before:
After:
At 120×32 and 140×40 the rows read "Open…", "Shrink…", "Step…", "Do…". The full description is already in the detail pane ("Open the command palette." further down on the right).
So when the layout is split, the rows leave the description out and the detail pane shows it.
render()already haslayout.stacked, so it's passed down toaction_row_line. The stacked layout below 100 columns and the 80-columnrender_linesexport keep their descriptions, and a disabled row's reason still follows its status.Issue
No-Issue: Hotbar setup rows show a lone "…" or one word of description beside the detail pane, no issue filed for it
How I tested it
action_row_linetest call passestruefor the new argument, and its word-boundary truncation assertions still hold.cargo fmt --all -- --check,cargo clippy -p codewhale-tui --all-targets --all-featureswith CI's flags, andcargo check -p codewhale-tui --all-targets: clean. Clippy also on 1.99, pluscargo +1.89.0 check -p codewhale-tui.cargo nextest run -p codewhale-tui --lib: 15347 passed, none failed, including the hotbar setup tests.Checklist
maincargo fmt --allpasses, and tests cover new or changed behaviordocs/features.toml(cargo test -p codewhale-tui --test feature_registrychecks it) — n/a