chore: make GENERATED_DIAGRAMS_REPO configurable via env var#23380
Open
ebembi-crdb wants to merge 1 commit into
Open
chore: make GENERATED_DIAGRAMS_REPO configurable via env var#23380ebembi-crdb wants to merge 1 commit into
ebembi-crdb wants to merge 1 commit into
Conversation
Allows the generated-diagrams repo reference in validate_branch_existence.py to be overridden via the GENERATED_DIAGRAMS_REPO environment variable. Defaults to `cockroachdb/generated-diagrams` (unchanged behavior since that repo is not moving). Part of Project Stanley (EDUENG-720, Ticket 5). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed:
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GENERATED_DIAGRAMS_REPOconstant invalidate_branch_existence.pyconfigurable via an environment variablecockroachdb/generated-diagrams(that repo is not moving orgs)Part of Project Stanley (EDUENG-720, Ticket 5).
Test plan
validate_branch_existence.pystill resolves branches correctly with the default valueGENERATED_DIAGRAMS_REPOenv var to confirm it's picked up🤖 Generated with Claude Code