[ceph-operations] exclude /dev/loop in CephNodeRootFilesystemFull

[defo89]

Summary by CodeRabbit

• Chores

  • Bumped the application chart version to 1.8.20 to keep releases current.

• Bug Fixes

  • Improved the filesystem-full alert so it no longer triggers for loop-mounted devices, reducing false positives for disk usage monitoring.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fd35f4f5-efc6-4d64-beae-02594e7a4b32

📥 Commits

Reviewing files that changed from the base of the PR and between afd5dc6 and 4bab46d.

📒 Files selected for processing (1)

• charts/ceph-operations/alerts/nodes.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• charts/ceph-operations/alerts/nodes.yaml

---

📝 Walkthrough

Walkthrough

Updated the ceph-operations Helm chart version from 1.8.19 to 1.8.20 and refined a Prometheus alert rule to exclude loop device filesystem metrics from the CephNodeRootFilesystemFull alert.

Changes

Cohort / File(s)	Summary
Helm Chart Metadata charts/ceph-operations/Chart.yaml	Bumped chart version from 1.8.19 to 1.8.20.
Alert Rules charts/ceph-operations/alerts/nodes.yaml	Modified CephNodeRootFilesystemFull PromQL to add device!~"/dev/loop.*" filters on node_filesystem_avail_bytes and node_filesystem_size_bytes, excluding loop devices from the percentage calculation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• sumitarora2786

Poem

🐰 Hop, hop, a tiny tweak tonight,
Version nudged up, neat and bright.
Loop devices hidden from the view,
Alerts hum steady, kind and true. 🥕✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title clearly and specifically describes the main change: excluding /dev/loop from the CephNodeRootFilesystemFull alert, which matches the primary modification in the alerts/nodes.yaml file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ceph-fs-full-loop0

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@charts/ceph-operations/alerts/nodes.yaml`:
- Line 9: The regex in the alert expression currently uses device!~"/dev/loop."
which only excludes single-character suffixes; update the label matcher(s) on
the metrics node_filesystem_avail_bytes and node_filesystem_size_bytes to
exclude all loop devices by changing device!~"/dev/loop." to a pattern that
matches any-length suffix (for example device!~"/dev/loop.*" or a full-anchor
like device!~"^/dev/loop[0-9]+$") so multi-digit loop devices (e.g. /dev/loop10)
are also excluded.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d6e74d97-23eb-4059-8204-4859b3571393

📥 Commits

Reviewing files that changed from the base of the PR and between da140b9 and afd5dc6.

📒 Files selected for processing (2)

• charts/ceph-operations/Chart.yaml
• charts/ceph-operations/alerts/nodes.yaml

[RockSolidScripts]

LGTM