Repository navigation
test: cover DirectoryFreshness's plain-text source fallbacks end-to-end - #1330
Merged
mrbobbytables merged 1 commit intoOct 12, 2026
Merged
Conversation
DirectoryFreshness names each provenance source as plain text when that source carries no URL (lines 30 and 44), and neither arm had ever run in a browser: the committed data always carries both URLs, and the e2e coverage artifact of run 38182984387 reported the file at 69.23% regions with 19, 30, 44 and 49 uncovered. Both arms need their sentence to render while the URL is absent, which conflicts with the ordinary coverage build (where the anchors at lines 26 and 40 are measured from) and with the variant build (which drops both sentences). tests/e2e/fixtures/data-no-revision/ already holds that shape and ReferenceArchitectures returns at its revision guard before reading sources.architectures.repository, so the two URLs are cleared there rather than in a new build directory, which would add a full Docusaurus compile to the End-to-end coverage job. Closes #1328 Signed-off-by: quality <quality@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will keep the |
This was referenced Oct 12, 2026
mrbobbytables
deleted the
quality/e2e-directory-freshness-unlinked-sources
branch
October 16, 2026 01:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
DirectoryFreshnessnames each provenance source as plain text when that source carries no URL:Both arms are ordinary shapes —
scripts/generate-members.mjsandnpm run collect:metricscan pin a source they cannot address by URL — but the committed data always carries both URLs, so neither had ever run in a browser.tests/e2e/member-directory-freshness.spec.jsasserts the other side and its comment already names this fallback.Evidence. The
e2e-coverageartifact (11718925360) of CI run 38182984387 — headfb75c1a— reported:Regions 19 and 49 are held by
tests/e2e/fixtures/data-variant/members.json; 30 and 44 were held by no build.What this adds
tests/e2e/fixtures/data-no-revision/metrics.json— also clearssources.architectures.repositorytests/e2e/fixtures/data-no-revision/members.json— new overlay clearingsources.landscape.sourceUrltests/e2e/member-directory-freshness-unlinked.spec.js— the real route renders both anchors; the no-revision route still renders both sentences, names both sources as text, and exposes no link in the note. A second case asserts the member grid is intact, so the first is evidence the ternary switched rather than that the page broke.tests/e2e-data-fixture-validity.test.mjsand the gated spec intests/e2e-coverage-describe-gate.test.mjsWhy
data-no-revisionand not a new buildEach fixture directory is a full Docusaurus compile, and the "End-to-end coverage" job grows linearly in their number (
tests/tools/e2e-data-fixtures.cjs). No new build is warranted here:collectedAtunparseable and clearsgeneratedAt, so neither sentence renders and the ternaries are never evaluated;ReferenceArchitecturesreturns at its revision guard (line 13) before readingsources.architectures.repository, so clearing the two URLs un-covers nothing that build reaches.CI cost of this PR: zero additional compiles.
Verification (local, this branch)
npm run test:unit:coverage:check— 2420 tests, 0 failures;src files 100.00 / 100.00, gate exits 0npm run build:e2e:coveragethen the full Playwright coverage run — 346 passed, includingreference-architectures-no-revision.spec.js, which proves the extra overlay does not disturb the build it rides onDirectoryFreshness.js | 100.00 | 91.67 | | 19— regions 69.23% → 91.67%, andsrc filesregions 97.27% → 97.73% (641/659 → 646/661). Only region 19 remains, which belongs to the variant build's attribution problem, not to this change.npx prettier --check .cleanRelated Issue
Closes #1328
Human review required.
— hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.88