[kumo] add sidebar transition completion callbacks - #798
Merged
mattrothenberg merged 5 commits intoSep 14, 2026
Merged
mattrothenberg merged 5 commits into
mattrothenberg merged 5 commits into
Conversation
7michele7
marked this pull request as ready for review
September 14, 2026 12:30
commit: |
Contributor
Docs PreviewCommit: |
Contributor
📐 Bundle SizeConsumer fixtures bundled against
npm tarball: 535 files, 1.47 MB packed, 6.85 MB unpacked.
|
Contributor
mattrothenberg
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
































































































Adds completion callbacks for sidebar and collapsible open-state transitions.
Consumers can wait for layout to settle before measuring or scrolling content.
The callbacks follow the owned CSS transition. They fall back when animations are interrupted or disabled.
Validation:
pnpm --filter @cloudflare/kumo exec vp test run --project=unit src/components/sidebar/sidebar.test.tsxpnpm --filter @cloudflare/kumo exec vp test run --project=unit --no-file-parallelismpnpm --filter @cloudflare/kumo typecheckpnpm --filter @cloudflare/kumo lintpnpm --filter @cloudflare/kumo build