Conversation
cjpatton
reviewed
Apr 21, 2026
Comment on lines
+3
to
+4
| //! ML-DSA-65 is the recommended parameter set, offering NIST security level 3 | ||
| //! (roughly equivalent to AES-192). |
Collaborator
There was a problem hiding this comment.
Recommended by whom? ML-DSA-44 is more likely than -65 to get used in TLS.
| } | ||
|
|
||
| /// Regenerates a private key from a seed value. | ||
| pub fn from_seed(algorithm: Algorithm, seed: &MlDsaSeed) -> Result<Self, ErrorStack> { |
Collaborator
There was a problem hiding this comment.
Note: RFC 9881 specifies a slightly more complicated DER encoding of MLDSA private keys that would be incompatible with the encoding here. We might need to at least partially implemented the complicated encoding, i.e., extract the seed and fail if the seed isn't present. This is what we're doing for internal use cases for Go. (happy to provide a reference.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.