Skip to content

Fix silent restore failures and broken reconciliation in elastic-reindex.sh#20

Open
Balatripura587 wants to merge 1 commit into
cloud-bulldozer:mainfrom
Balatripura587:reindex_reconcilation
Open

Fix silent restore failures and broken reconciliation in elastic-reindex.sh#20
Balatripura587 wants to merge 1 commit into
cloud-bulldozer:mainfrom
Balatripura587:reindex_reconcilation

Conversation

@Balatripura587

Copy link
Copy Markdown

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

During investigation of missing data in intlab, identified that restore failures in publish_to_destination are silently skipped and the reconciliation check is not accurate.

Changes

  • Track restore failures via RESTORE_FAILED flag instead of silently continuing
  • Capture elasticdump Total Writes for both backup and restore steps
  • Replace broken destination count comparison with backup-vs-restore write verification
  • Use exit 1 for failures (triggers Slack alert) instead of exit 3 (treated as success)
  • Only write touch file after reconciliation passes

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Signed-off-by: Bala Tripura Kumari Bodapati <bbodapat@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant