Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WasmModule.vmnullable so thatloadLinkedcan safely fail after Phase 1 without leaving UB behind (fix: avoid crash on OOM by safe-guarding uninitialized VM pointer zwasm#40 by @jtakakura, closes WasmModule.loadLinked may return partially initialized module on OOM zwasm#39). Addserror.ModuleNotFullyLoadedfrominvoke/invokeInterpreterOnlyin that path, and fixes a segfault whereWasmModule.cancel()would dereference a null VM. No breaking changes for CW — the happy-path API is unchanged.Test plan
zig build— clean build greenbash test/run_all.sh --quick— 4/4 pass (zig build test, cljw test 83 namespaces, e2e wasm, deps.edn e2e)