Publish GitHub release after release jobs#5468
Open
clockwork-labs-bot wants to merge 5 commits into
Open
Conversation
clockwork-labs-bot
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
bfops
reviewed
Jul 1, 2026
| --ref master \ | ||
| -f "release_tag=${RELEASE_TAG}" | ||
|
|
||
| run_id="" |
Collaborator
There was a problem hiding this comment.
gh workflow run returns the url of the workflow. use that instead.
Contributor
Author
There was a problem hiding this comment.
Moved the artifact dispatch into cargo-release release github-release; it now uses the workflow URL returned by gh workflow run instead of polling for a matching run.
bfops
reviewed
Jul 1, 2026
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| RELEASE_TAG: ${{ github.event.inputs.release_tag }} | ||
| steps: | ||
| - name: Verify release exists |
Collaborator
There was a problem hiding this comment.
please convert this entire job into something under cargo-release and call it in a single step here
Contributor
Author
There was a problem hiding this comment.
Done in 18bf4deda: the workflow job now downloads cargo-release and calls a single cargo-release release github-release ... step. The release/artifact/publish logic lives under tools/release/src/targets/github_release.rs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds a final
publish-github-releasejob to the manual release workflow. On non-dry-run releases, it waits for all release jobs to finish successfully or be skipped, then callscargo-release release github-release.The new release-tool target verifies the target GitHub release is still a draft, dispatches
attach-artifacts.ymlusing the workflow URL returned bygh workflow run, waits for that artifact workflow to complete, and then publishes the release. If the release is already published, the command exits successfully without re-uploading artifacts.API and ABI breaking changes
None.
Expected complexity level and risk
cargo-releasetarget. The risky part is release sequencing, so the workflow keeps explicitneedschecks and the publish logic fails before publication if artifact attachment does not succeed.Testing
ruby -e 'require "yaml"; YAML.load_file(".github/workflows/release.yml")'git diff --checkPATH=/Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin:$PATH cargo check --manifest-path tools/release/Cargo.tomlPATH=/Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin:$PATH cargo run --manifest-path tools/release/Cargo.toml -- release github-release --helpactionlint .github/workflows/release.ymlwas not run becauseactionlintis not installed locally.