Make dst crate a lib in public.#5466
Open
Shubham8287 wants to merge 1 commit into
Open
Conversation
Shubham8287
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
Shubham8287
force-pushed
the
shub/async-dst
branch
2 times, most recently
from
9346d65 to
08675c8
Compare
Shubham8287
force-pushed
the
shub/async-dst
branch
from
6cf56fd to
6da287d
Compare
Shubham8287
requested review from
jsdt
and removed request for
bfops,
cloutiertyler and
jdetter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Makes
spacetimedb-dsttospacetimedb-dst-lib.To be able to write tests for private repo, We have two options:
libwith test covering public specific code, and write abinin private,I chose option 2 as it's easier to maintain tests like this, else you may have to raise a separate PR for changes in
enginecrate, which will be painful.This also makes methods of
TestSuiteasync.binary crate PR - https://github.com/clockworklabs/SpacetimeDBPrivate/pull/3287
API and ABI breaking changes
NA
Expected complexity level and risk
1
Testing
Not applicable.