Fix generate config target fallback#5432
Open
clockwork-labs-bot wants to merge 2 commits into
Open
Conversation
bfops
reviewed
Jun 23, 2026
| } | ||
| } | ||
|
|
||
| fn fallback_generate_configs_from_targets<'a>( |
Collaborator
There was a problem hiding this comment.
document what this function's for
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #4475.
When
spacetime generateloadsspacetime.jsonbut the selected config target has nogenerateentries, preserve the selected target's entity fields instead of falling back to an empty config.This keeps root-level and child-level fields such as
module-pathavailable togenerateeven when the user is driving language/output settings from CLI flags. Unsupported entity fields such asdatabaseandserverare filtered through the command schema before building the fallbackCommandConfig.This also moves that filtering into
CommandSchemaso command fallbacks do not need to hand-roll schema-key filtering.API and ABI breaking changes
None.
Expected complexity level and risk
The change is mostly local to CLI config resolution for
spacetime generate, but it touches the shared config schema helper so the fallback path can filter entity fields consistently.Testing