Skip to content

fix(backend): Add samlConnection and oauthConfig into EnterpriseConnection#8326

Merged
LauraBeatris merged 2 commits intomainfrom
laura/fix-enterprise-connection-mapping
Apr 15, 2026
Merged

fix(backend): Add samlConnection and oauthConfig into EnterpriseConnection#8326
LauraBeatris merged 2 commits intomainfrom
laura/fix-enterprise-connection-mapping

Conversation

@LauraBeatris
Copy link
Copy Markdown
Member

@LauraBeatris LauraBeatris commented Apr 15, 2026

Description

This PR fixes the EnterpriseConnection resource from @clerk/backend to serialize the saml_connection and oauth_provider fields

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@LauraBeatris LauraBeatris self-assigned this Apr 15, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 15, 2026

🦋 Changeset detected

Latest commit: 970266d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@clerk/backend Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/hono Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Apr 15, 2026 9:49pm

Request Review

@LauraBeatris LauraBeatris marked this pull request as ready for review April 15, 2026 21:36
@LauraBeatris LauraBeatris requested a review from a team April 15, 2026 21:37
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 15, 2026

📝 Walkthrough

Walkthrough

This pull request extends the enterprise connection API to include nested SAML and OAuth configuration objects. It adds two new model classes (EnterpriseConnectionSamlConnection, EnterpriseConnectionOauthConfig) with fromJSON factories, updates EnterpriseConnection to include nullable samlConnection and oauthConfig properties, introduces corresponding JSON interfaces, updates public exports, and expands test fixtures/assertions to validate mapping of these nested structures.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Notes

The changes follow a consistent pattern across multiple files: introducing new typed model classes with JSON factory methods, updating the parent model to include these as nested properties, defining the corresponding JSON interface types, and exporting them publicly. While the scope spans four files, the logic is straightforward property mapping with no complex business logic or structural refactoring. Test coverage validates the expected mappings of the new nested objects.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description is related to the changeset, explaining that the PR fixes serialization of saml_connection and oauth_provider fields in EnterpriseConnection.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The PR title describes adding samlConnection and oauthConfig to EnterpriseConnection, which is the core change, but the actual PR description mentions 'oauth_provider' while the code adds 'oauthConfig', creating a minor inconsistency.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@LauraBeatris LauraBeatris changed the title fix(backend): Serialize samlConnection and oauthProvider from EnterpriseConnection fix(backend): Introduce samlConnection /oauthConfig into EnterpriseConnection Apr 15, 2026
@LauraBeatris LauraBeatris changed the title fix(backend): Introduce samlConnection /oauthConfig into EnterpriseConnection fix(backend): Introduce samlConnection/oauthConfig into EnterpriseConnection Apr 15, 2026
@LauraBeatris LauraBeatris changed the title fix(backend): Introduce samlConnection/oauthConfig into EnterpriseConnection fix(backend): Introduce samlConnection and oauthConfig into EnterpriseConnection Apr 15, 2026
@LauraBeatris LauraBeatris changed the title fix(backend): Introduce samlConnection and oauthConfig into EnterpriseConnection fix(backend): Add samlConnection and oauthConfig into EnterpriseConnection Apr 15, 2026
@LauraBeatris LauraBeatris changed the title fix(backend): Add samlConnection and oauthConfig into EnterpriseConnection fix(backend): Add samlConnection and oauthConfig into EnterpriseConnection Apr 15, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 15, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8326

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8326

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8326

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8326

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8326

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8326

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8326

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8326

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8326

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8326

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8326

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8326

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8326

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8326

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8326

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8326

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8326

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8326

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8326

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8326

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8326

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8326

commit: 970266d

@LauraBeatris LauraBeatris enabled auto-merge (squash) April 15, 2026 21:56
@LauraBeatris LauraBeatris merged commit f800b4f into main Apr 15, 2026
48 of 52 checks passed
@LauraBeatris LauraBeatris deleted the laura/fix-enterprise-connection-mapping branch April 15, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants