fix(staking): remove debug prints from delegation hook - #672
Merged
fragwuerdig merged 2 commits intoSep 28, 2026
Merged
Conversation
AfterDelegationModified printed debug lines to stdout on every delegation on columbus-5, spamming node logs. Behavior is otherwise unchanged.
The strangelove-ventures GitHub org was renamed/moved to amygdala-labs, which killed the ghcr.io/strangelove-ventures/heighliner/osmosis image path baked into interchaintest's built-in chain config. Both PFM tests (TestTerraGaiaOsmoPFM, TestTerraPFM) now fail during chain setup with "denied" when pulling the image, independent of the code under test. Override the osmosis image repository per ChainSpec (the spec-level Images list replaces the built-in one; ChainSpec.Version still applies to Images[0]) to the same tags under the new amygdala-labs org. Verified the replacement manifests are pullable. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Contributor
Author
|
Quick question to make sure this matches your intent: the DEBUG fmt.Printf lines in If you actually rely on them for live monitoring of the power-limit check on mainnet, happy to convert them to proper |
fragwuerdig
self-requested a review
September 23, 2026 18:55
fragwuerdig
approved these changes
Sep 23, 2026
fragwuerdig
left a comment
fragwuerdig
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - Will marking this as blocked, though - as we are waiting for the Cosmos Labs Security Fix release on 28th of September.
StrathCole
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TerraStakingHooks.AfterDelegationModified(custom/staking/hook.go) printed a dozenfmt.Printf("DEBUG: ...")lines to stdout on every delegation on columbus-5, spamming node logs with per-delegation debug output on mainnet.This removes the debug prints and an unused counter that existed only for them. Behavior is otherwise unchanged — the power-limit check itself is untouched.
Testing
go build,go vet,gofmtand thecustom/stakingtest suite pass in a CI-parity Linux container (golang:1.24). Logs-only change; no consensus impact.