Skip to content

fix(core): harden reCheckAdminAuths error handling - #1143

Open
mattibat wants to merge 2 commits into
citizenfx:developfrom
mattibat:fix/recheck-admin-auths
Open

fix(core): harden reCheckAdminAuths error handling#1143
mattibat wants to merge 2 commits into
citizenfx:developfrom
mattibat:fix/recheck-admin-auths

Conversation

@mattibat

@mattibat mattibat commented Sep 17, 2026

Copy link
Copy Markdown

Problem

  • Invalid session on one socket skipped all remaining sockets
  • Errors from reCheckAdminAuths() were silently swallowed

Fix

  • Loop now continues past a socket with an invalid session
  • Errors are now logged

@mattibat
mattibat requested a review from tabarra as a code owner September 17, 2026 18:42
@mattibat
fix(core): don't skip remaining sockets when one has an invalid sessi…
88f9b92 
…on in reCheckAdminAuths

Signed-off-by: matti.bat <138713607+mattibat@users.noreply.github.com>
@mattibat
fix(core): log errors from reCheckAdminAuths instead of swallowing them
92ae3d4 
Signed-off-by: matti.bat <138713607+mattibat@users.noreply.github.com>
@mattibat
mattibat force-pushed the fix/recheck-admin-auths branch from 8b6133a to 92ae3d4 Compare September 17, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tabarra tabarra Awaiting requested review from tabarra tabarra is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mattibat