Repository navigation
ci: Add support for OIDC - #3313
Merged
Merged
Conversation
aanm
marked this pull request as ready for review
September 25, 2026 13:00
aanm
marked this pull request as draft
September 25, 2026 13:15
aanm
force-pushed
the
pr/aanm/quay-oidc-robot-variables
branch
from
September 25, 2026 13:29
8a7bf9a to
747bc15
Compare
This commit adds support for OIDC, replacing long-lived tokens. Quay.io has been configured accordingly. The robot account names are read from the QUAY_ROBOT_CI and QUAY_ROBOT_RELEASE variables, defined on the GitHub environments the jobs pin rather than at repository or organisation level, so the value a job receives is the one belonging to its environment. The environment name also forms the OIDC subject that the robot is configured to trust, so renaming an environment breaks the login. Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/aanm/quay-oidc-robot-variables
branch
from
September 25, 2026 14:47
747bc15 to
ac0a15c
Compare
Member
Author
|
Tested with a temporary DO NOT MERGE commit that switches images-dev.yaml to pull_request: https://github.com/cilium/cilium-cli/actions/runs/36422913345. The run got the robot token through OIDC and pushed quay.io/cilium/cilium-cli-ci:abaed675af4fdce2b4b25a93cacdf410c4badc2f@sha256:0f48a5c6b838aaa59133a1eececccb90153a3250e7ad2f033e3a0c07cf833622. |
aanm
force-pushed
the
pr/aanm/quay-oidc-robot-variables
branch
from
September 28, 2026 12:43
abaed67 to
ac0a15c
Compare
aanm
marked this pull request as ready for review
September 28, 2026 14:12
tklauser
approved these changes
Sep 29, 2026
michi-covalent
approved these changes
Oct 5, 2026
nbusseneau
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for OIDC, replacing long-lived tokens. Quay.io
has been configured accordingly.
The robot account names are read from the QUAY_ROBOT_CI and
QUAY_ROBOT_RELEASE variables, defined on the GitHub environments the
jobs pin rather than at repository or organisation level, so the value a
job receives is the one belonging to its environment. The environment
name also forms the OIDC subject that the robot is configured to trust,
so renaming an environment breaks the login.