Skip to content

feat: scale plan segments by exposure length - #327

Merged
chvvkumar merged 1 commit into
devfrom
snd
Oct 13, 2026
Merged

chvvkumar merged 1 commit into
devfrom
snd

Conversation

@chvvkumar

@chvvkumar chvvkumar commented Oct 13, 2026 •

Copy link
Copy Markdown
Owner

Summary

The application now displays the planned exposure length in the image-forward field. It also draws sub bar and sub ring segments proportionally to each image's exposure length, providing a more accurate visual representation of the imaging plan.

Changes

  • Display the planned exposure length, such as "/ 420s", above the elapsed digits in the image-forward field.
  • Sub bar and sub ring segments now draw proportionally to each image's exposure length, rather than a fixed unit per image.
  • nina_plan_item_t includes a new exposure_s field to store the planned exposure time in seconds.
  • nina_seg_t includes a new span field to represent the segment's duration in seconds.
  • Segment calculation logic uses the span value for ring angles and to scale row flex grow.
  • The segment rebuild fingerprint now incorporates the exposure length.
  • A new host test (d2) validates the updated segment behavior with a specific exposure plan.

Analyzed 1 commit(s) | Updated: 2026-10-13T01:55:41.552Z | Generated by GitHub Actions

…ts by exposure seconds

Image-forward (square) bottom-right field now stacks "/ 420s" in Hanken 28
above the elapsed digits, right aligned in the same fixed box sized to
"9999s" at 64, painted in the counter's text colour. The value band grows
upward by that line; everything else is bottom-aligned and does not move.

Sub bar and sub ring segments are drawn proportional to each image's
exposure length instead of one unit per image: nina_plan_item_t gains
exposure_s (Smart Exposure ExposureTime), nina_seg_t gains span (seconds,
1 when unknown so demo mode and plan-less sources draw as before). weight
stays the image count for the fill maths. Row flex grow scales the widest
span to 255; ring angles use span directly; the rebuild fingerprint
includes it. Applies to every layout that draws segments on both families.

Host test d2 added with the live astromele1 shape (L 240 s x 2, Ha 420 s
x 1); 25/25 host tests pass.
@github-actions github-actions Bot changed the title feat(nina): exposure length over the Image-forward digits, sub segmen… feat: scale plan segments by exposure length Oct 13, 2026
@chvvkumar
chvvkumar merged commit 6237e17 into dev Oct 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant