fix(confirm): remove hardcoded "access continues until" notice#27
Merged
Conversation
The confirm step always rendered "Your access continues until {date}."
whenever the subscription had a current period, with no awareness of the
merchant's cancel mode. For merchants using immediate cancellation there
is no continued access, so the sentence was incorrect and could not be
turned off via config.
Removes the notice from DefaultConfirm and updates the test to assert it
no longer renders. The formatPeriodEnd helper and periodEndNotice
classNames key are left in place to avoid a breaking API change.
lucasksoares
force-pushed
the
fix/remove-access-continues-notice
branch
from
3c89b73 to
b31e1ba
Compare
robert-moore
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Retention team feedback (Motley Fool): the "Your access continues until {date}." line on the confirm step must go. It rendered whenever the subscription had a
currentPeriod.end, with no awareness of the cancel mode — so it showed even under "cancel immediate", where there is no continued access, and couldn't be turned off via config.Change
ck-period-endnotice (plus the now-unusedformatPeriodEnd(...)call and import) fromDefaultConfirm.formatPeriodEnd, theperiodEndNoticeclassNames key, and the.ck-period-endCSS are left in place to keep the change non-breaking.Verification
vitest run— 169 passed / 8 skippedbiome check— clean