Expose externalId on PlanOption#26
Closed
robert-moore wants to merge 1 commit into
Closed
Conversation
When a plan-change option is configured with a merchant's external offer id, the server now sends it on the resolved plan. Type it on PlanOption so handlePlanChange consumers can map a chosen plan back to their own catalog — needed when one Stripe price backs several of their offers. The value already flows through at runtime (config is cast, not field-mapped); this makes it a typed, documented field.
Contributor
Author
|
Closing for now in favor of custom offer types |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
externalId?: stringtoPlanOption. When a plan-change option is configured with a merchant's external offer id (see the churnkey-api change), the server sends it on the resolved plan; this types it sohandlePlanChangeconsumers can map the chosen plan back to their own catalog — needed when one Stripe price backs several of their offers.Non-breaking, type-only: the value already reaches the callback at runtime (the SDK config is cast, not field-mapped). typecheck + build + lint + tests clean.